[PATCH] D135597: [LangRef] Add memory attribute

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

Do we need two spelling "``memory()`` or ``memory(none)``:"?

We should talk about call sites not calls, as we refer to them as "call site attributes".



================
Comment at: llvm/docs/LangRef.rst:1750
+    - ``memory(readwrite, argmem: none)``: May access any memory apart from
+      argument memory.
+
----------------
There is no explicit "other" example, if we introduce the keyword we should use it. If we don't introduce the keyword we should not specify it as ``other`` but rather spell out non specified location kind means all non-specified locations kinds.


================
Comment at: llvm/docs/LangRef.rst:1772
+    ``memory`` attribute with the union of the function ``memory`` attribute
+    and any effects implied by operand bundles.
 ``minsize``
----------------
intersection ... union ... does at best read confusing. Either we need to "union" both sides first or we just don't talk about that and simply write:
```
 The memory effects of a call is the intersection of the call-site
    ``memory`` attribute with the function ``memory`` attribute and any effects implied by operand bundles.
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135597/new/

https://reviews.llvm.org/D135597