[PATCH] D135693: [WIP][RegisterScavenger][RISCV] Don't search for FrameSetup instrs if we were searching from Non-FrameSetup instrs

luxufan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 12 07:42:56 PDT 2022


StephenFan added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/out-of-reach-emergency-slot.mir:33
+  ; CHECK-NEXT:    slli sp, a0, 12
+  ; CHECK-NEXT:    ld a0, 0(sp)
   ; CHECK-NEXT:    sd a1, 0(sp)
----------------
craig.topper wrote:
> This doens't look correct either.
This test case is tricky and rare. We may need to implement the target hook saveScavengerRegister to fix it. So I left a FIXME.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135693/new/

https://reviews.llvm.org/D135693



More information about the llvm-commits mailing list