[PATCH] D135679: [Attributes] Make intrinsic attribute generation more flexible (NFC)

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks accepted this revision.
aeubanks added a comment.
This revision is now accepted and ready to land.

I measured building llvm-dis

perf stat:
before this patch: 1749B instructions
after this patch: 1752B instructions
(only generating the intrinsic files gives ~1B instruction increase)

llvm-dis size:
before this patch: 17860464 bytes
after this patch: 17877312 bytes

the compile time increase looks non-trivial but is probably ok



================
Comment at: llvm/utils/TableGen/IntrinsicEmitter.cpp:883
 
     if (!Intrinsic.canThrow ||
         (Intrinsic.ModRef != CodeGenIntrinsic::ReadWriteMem &&
----------------
I guess the alternative would be to have another `hasAtLeastOneAttribute` bool in the entries for `UniqFnAttributes` that's set when populating `UniqFnAttributes`, but that's not that much better


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135679/new/

https://reviews.llvm.org/D135679