[PATCH] D135679: [Attributes] Make intrinsic attribute generation more flexible (NFC)

[Nikita Popov via Phabricator via llvm-commits]

nikic created this revision.
nikic added reviewers: aeubanks, serge-sans-paille.
Herald added a project: All.
nikic requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Currently attributes for intrinsics are emitted using the `ArrayRef<AttrKind>` based constructor for `AttributeList`s. This works out fine for simple enum attributes, but doesn't really generalize to attributes that accept values. We're already doing something awkward for alignment attributes, and I'd like to have a cleaner solution to this with https://discourse.llvm.org/t/rfc-unify-memory-effect-attributes/65579 in mind.

The new generation approach is to instead directly construct `Attribute`s, giving us access to the full generality of that interface. To avoid significantly increasing the size of the generated code, we now also deduplicate the attribute sets. The code generated per unique AttributeList looks like this:

  case 204: {
    AS[0] = {1, getIntrinsicArgAttributeSet(C, 5)};
    AS[1] = {AttributeList::FunctionIndex, getIntrinsicFnAttributeSet(C, 10)};
    NumAttrs = 2;
    break;
  }

and then the helper functions contain something like

  case 5:
    return AttributeSet::get(C, {
      Attribute::get(C, Attribute::NoCapture),
    });

and

  case 10:
    return AttributeSet::get(C, {
      Attribute::get(C, Attribute::NoUnwind),
      Attribute::get(C, Attribute::ArgMemOnly),
    });

A casualty of this change is the `intrin-properties.td` test, as I don't think that FileCheck allows matching this kind of output.


https://reviews.llvm.org/D135679

Files:
  llvm/test/TableGen/intrin-properties.td
  llvm/test/TableGen/intrin-side-effects.td
  llvm/utils/TableGen/CodeGenIntrinsics.h
  llvm/utils/TableGen/IntrinsicEmitter.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D135679.466813.patch
Type: text/x-patch
Size: 20623 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221011/05ae81e5/attachment.bin>