[PATCH] D135539: llvm-reduce: Don't write out IR to score IR complexity

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 11 13:02:33 PDT 2022


arsenm added inline comments.


================
Comment at: llvm/tools/llvm-reduce/ReducerWorkItem.cpp:608
+    if (isa<UndefValue>(V) || isa<PoisonValue>(V))
+      return 0;
+    if (C->isNullValue())
----------------
aeubanks wrote:
> aeubanks wrote:
> > I thought we wanted undef to be more expensive than 0?
> ping, maybe lump undef into `return 3`?
Why would undef be treated as complex?

So far the actual scoring doesn't matter and we could probably do as well with a content  agnostic  hash that indicates some change occurred 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135539/new/

https://reviews.llvm.org/D135539



More information about the llvm-commits mailing list