[PATCH] D135539: llvm-reduce: Don't write out IR to score IR complexity

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 11 12:48:41 PDT 2022


aeubanks accepted this revision.
aeubanks added a comment.
This revision is now accepted and ready to land.

lgtm with one more question



================
Comment at: llvm/tools/llvm-reduce/ReducerWorkItem.cpp:608
+    if (isa<UndefValue>(V) || isa<PoisonValue>(V))
+      return 0;
+    if (C->isNullValue())
----------------
aeubanks wrote:
> I thought we wanted undef to be more expensive than 0?
ping, maybe lump undef into `return 3`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135539/new/

https://reviews.llvm.org/D135539



More information about the llvm-commits mailing list