[PATCH] D135611: [llvm] Update WPD tests to use opaque pointers

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: llvm/test/Transforms/WholeProgramDevirt/import-no-dominating-assume.ll:1
-; RUN: opt -S -passes=wholeprogramdevirt -wholeprogramdevirt-summary-action=import -wholeprogramdevirt-read-summary=%S/Inputs/import-vcp.yaml < %s | FileCheck %s
+;; TODO: This test explicitly checks for a bitcast instrumented in with WPD.
+;; The bitcast looks to be necessary since the llvm.assume may not dominate
----------------
tejohnson wrote:
> "instrumented in with WPD" doesn't sound right to me. Maybe "added by WPD"?
> 
> @pcc added this test, hopefully he can advise. If we no longer need to test non-opaque pointers then it seems like this test could be removed, but hopefully he can confirm.
Yes, this test was added to test for an edge case that no longer exists with opaque pointers, so we should be able to remove it if we no longer test non-opaque pointers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135611/new/

https://reviews.llvm.org/D135611