[PATCH] D135611: [llvm] Update WPD tests to use opaque pointers

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added a comment.

Thanks. Per https://llvm.org/docs/OpaquePointers.html#version-support it sounds like non-opaque pointers are now only best effort and no longer need to be tested, since LLVM 15 has branched - is that correct?



================
Comment at: llvm/test/Transforms/WholeProgramDevirt/import-no-dominating-assume.ll:1
-; RUN: opt -S -passes=wholeprogramdevirt -wholeprogramdevirt-summary-action=import -wholeprogramdevirt-read-summary=%S/Inputs/import-vcp.yaml < %s | FileCheck %s
+;; TODO: This test explicitly checks for a bitcast instrumented in with WPD.
+;; The bitcast looks to be necessary since the llvm.assume may not dominate
----------------
"instrumented in with WPD" doesn't sound right to me. Maybe "added by WPD"?

@pcc added this test, hopefully he can advise. If we no longer need to test non-opaque pointers then it seems like this test could be removed, but hopefully he can confirm.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135611/new/

https://reviews.llvm.org/D135611