[PATCH] D135166: [DebugInfo] getMergedLocation: Maintain the line number if they match
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 10 11:35:52 PDT 2022
dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.
I'm generally OK with this.
Might be worth getting some feedback from folks - but I think it's probably fairly harmless (lots of code is built without column info anyway, so tools are likely fine with it) & things can be addressed in post-commit review. But also doesn't seem like it'd need to be rushed in either - so waiting for some Sony/Apple feedback for a bit seems fine - either way.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135166/new/
https://reviews.llvm.org/D135166
More information about the llvm-commits
mailing list