[PATCH] D135512: [AArch64][Windows] Check sret attribute also for inreg attribute

David Spickett via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 10 02:39:34 PDT 2022


DavidSpickett resigned from this revision.
DavidSpickett added a comment.

I have zero idea what either InReg or SRet are, I'll leave the actual review to others.



================
Comment at: llvm/test/CodeGen/AArch64/aarch64-windows-inreg-without-sret.ll:3
+; RUN: llc < %s | FileCheck %s
+
+target datalayout = "e-m:w-p:64:64-i32:32-i64:64-i128:128-n32:64-S128"
----------------
Please comment the intent of the test. E.g.

"When there is inreg but not sret, we should emit..."


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135512/new/

https://reviews.llvm.org/D135512



More information about the llvm-commits mailing list