[PATCH] D135353: Add script to download prerequisites for Windows build

[Pierrick Bouvier via Phabricator via llvm-commits]

pbo-linaro marked 3 inline comments as done.
pbo-linaro added inline comments.


================
Comment at: llvm/utils/release/download_prerequisites.bat:37
+echo Those dependencies are just downloaded, and you can install them
+echo system-wide manually
+set url_vs2019=https://aka.ms/vs/16/release/vs_community.exe
----------------
hans wrote:
> I suppose VS is tricky, but for Python  and Perl, it would be *really* nice if they could also be handled automatically. Don't they have any official zip files we could use?
Python and Perl have portable version, but as discussed [[ https://discourse.llvm.org/t/build-llvm-release-bat-script-dependencies/65657/4?u=pbo-linaro | here ]], the python used for build will be a dependency at runtime for lldb. Since that involves to packages python *with* llvm release, there is more work involved.

For Perl, I don't know exactly how it's used, but the comment "OpenMP runtime" made me adopt a prudent approach.




================
Comment at: llvm/utils/release/download_prerequisites.bat:93
+taskkill /IM gpg-agent.exe /f
+where 7z || exit /b 1
+exit /b 0
----------------
hans wrote:
> copy-paste-o from get_7z?
Good catch, thanks


================
Comment at: llvm/utils/release/download_prerequisites.bat:128
+call :download "NSIS" "%url_nsis_patch%" nsis_patch.zip || exit /b 1
+REM overwrite some files with patch
+unzip -o nsis_patch.zip || exit /b 1
----------------
hans wrote:
> I'll be very happy not to have to do this manually ever again :-)
yes. The worse part in this script was finding how to escape url. Batch is really... exotic, to stay polite.


================
Comment at: llvm/utils/release/download_prerequisites.bat:151
+::===============================================================
+:get_nuget
+mkdir nuget && pushd nuget
----------------
hans wrote:
> I'm not actually sure we need nuget at the moment? It was used when we built the visual studio clang-format plugin, but that was dropped a while ago.
Ok, I can probably remove this then. Just included that based on an original comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135353/new/

https://reviews.llvm.org/D135353