[PATCH] D135353: Add script to download prerequisites for Windows build

[Hans Wennborg via Phabricator via llvm-commits]

hans added inline comments.


================
Comment at: llvm/utils/release/download_prerequisites.bat:17
+mkdir %out_folder%
+pushd %out_folder%
+
----------------
Whoa, I had not realized pushd/popd is a thing on Windows.


================
Comment at: llvm/utils/release/download_prerequisites.bat:37
+echo Those dependencies are just downloaded, and you can install them
+echo system-wide manually
+set url_vs2019=https://aka.ms/vs/16/release/vs_community.exe
----------------
I suppose VS is tricky, but for Python  and Perl, it would be *really* nice if they could also be handled automatically. Don't they have any official zip files we could use?


================
Comment at: llvm/utils/release/download_prerequisites.bat:93
+taskkill /IM gpg-agent.exe /f
+where 7z || exit /b 1
+exit /b 0
----------------
copy-paste-o from get_7z?


================
Comment at: llvm/utils/release/download_prerequisites.bat:101
+call :download "7zip" %url_7zip% 7zip_setup.exe || exit /b 1
+:: extract using msys2 7z
+7z x 7zip_setup.exe || exit /b 1
----------------
Clever :)


================
Comment at: llvm/utils/release/download_prerequisites.bat:128
+call :download "NSIS" "%url_nsis_patch%" nsis_patch.zip || exit /b 1
+REM overwrite some files with patch
+unzip -o nsis_patch.zip || exit /b 1
----------------
I'll be very happy not to have to do this manually ever again :-)


================
Comment at: llvm/utils/release/download_prerequisites.bat:151
+::===============================================================
+:get_nuget
+mkdir nuget && pushd nuget
----------------
I'm not actually sure we need nuget at the moment? It was used when we built the visual studio clang-format plugin, but that was dropped a while ago.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135353/new/

https://reviews.llvm.org/D135353