[PATCH] D134990: [CMake] Provide Findzstd module

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 6 03:05:35 PDT 2022


nikic added a comment.

I've reverted this patch because it breaks running LLVM tests with:

  llvm-lit: /home/npopov/repos/llvm-project/llvm/utils/lit/lit/TestingConfig.py:138: fatal: unable to parse config file '/home/npopov/repos/llvm-project/build/test/lit.site.cfg.py', traceback: Traceback (most recent call last):
    File "/home/npopov/repos/llvm-project/llvm/utils/lit/lit/TestingConfig.py", line 127, in load_from_path
      exec(compile(data, path, 'exec'), cfg_globals, None)
    File "/home/npopov/repos/llvm-project/build/test/lit.site.cfg.py", line 48, in <module>
      config.have_zstd = FALSE
  NameError: name 'FALSE' is not defined

I expect this is just a matter of a missing llvm_canonicalize_cmake_booleans entry, but it's not completely obvious to me how this is related to this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134990/new/

https://reviews.llvm.org/D134990



More information about the llvm-commits mailing list