[PATCH] D134990: [CMake] Provide Findzstd module

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 6 01:26:26 PDT 2022


phosek added a comment.

In D134990#3836334 <https://reviews.llvm.org/D134990#3836334>, @mgorny wrote:

> I think it's good enough for us. I wish you'd have implemented the improvements from my version but I can work on top of this.

I'd prefer adding functionality such as the `pkg-config` support in a follow up change. We would need to ensure it works correctly on systems that don't have `pkg-config` like Windows. I'd also prefer doing this consistently across all `Find*.cmake` modules; we currently don't support `pkg-config` in any of them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134990/new/

https://reviews.llvm.org/D134990



More information about the llvm-commits mailing list