[llvm] 7449570 - [ConstraintElimination] Use ConstraintTy::IsSigned instead of Predicate.

Florian Hahn via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 5 23:52:06 PDT 2022


Author: Florian Hahn
Date: 2022-10-06T07:51:49+01:00
New Revision: 7449570ff74abaf0761e98a7d5bfe573825c3068

URL: https://github.com/llvm/llvm-project/commit/7449570ff74abaf0761e98a7d5bfe573825c3068
DIFF: https://github.com/llvm/llvm-project/commit/7449570ff74abaf0761e98a7d5bfe573825c3068.diff

LOG: [ConstraintElimination] Use ConstraintTy::IsSigned instead of Predicate.

This should be NFC and ensure the sign of the constraint is used
consistently in the future.

Added: 
    

Modified: 
    llvm/lib/Transforms/Scalar/ConstraintElimination.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Transforms/Scalar/ConstraintElimination.cpp b/llvm/lib/Transforms/Scalar/ConstraintElimination.cpp
index fd10497ad8ff..7586e5017d7e 100644
--- a/llvm/lib/Transforms/Scalar/ConstraintElimination.cpp
+++ b/llvm/lib/Transforms/Scalar/ConstraintElimination.cpp
@@ -434,8 +434,7 @@ bool ConstraintInfo::doesHold(CmpInst::Predicate Pred, Value *A,
     return false;
 
   return NewVariables.empty() && R.Preconditions.empty() && !R.IsEq &&
-         !R.empty() &&
-         getCS(CmpInst::isSigned(Pred)).isConditionImplied(R.Coefficients);
+         !R.empty() && getCS(R.IsSigned).isConditionImplied(R.Coefficients);
 }
 
 void ConstraintInfo::transferToOtherSystem(
@@ -681,7 +680,7 @@ tryToSimplifyOverflowMath(IntrinsicInst *II, ConstraintInfo &Info,
     if (R.size() < 2 || !NewVariables.empty() || !R.isValid(Info))
       return false;
 
-    auto &CSToUse = Info.getCS(CmpInst::isSigned(Pred));
+    auto &CSToUse = Info.getCS(R.IsSigned);
     return CSToUse.isConditionImplied(R.Coefficients);
   };
 


        


More information about the llvm-commits mailing list