[PATCH] D135237: [llvm-reduce] Remove debug metadata elements

Ellis Hoag via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 5 12:56:18 PDT 2022


ellis added inline comments.


================
Comment at: llvm/test/tools/llvm-reduce/remove-debug-info-nodes.ll:15-18
+; CHECK-INTERESTINGNESS-DAG: !{{DIGlobalVariable}}(
+; CHECK-INTERESTINGNESS-DAG: !{{DILocalVariable}}(name: "A"
+; CHECK-INTERESTINGNESS-DAG: !{{DILocalVariable}}(name: "B"
+; CHECK-INTERESTINGNESS-DAG: !{{DILocalVariable}}(name: "C"
----------------
dblaikie wrote:
> The `DILocalVariable`s don't need `{{``}}` do they?
Hmm I originally added this because I didn't want these lines to match themselves. But I guess after the first iteration the comments will be removed and they wont' match themselves anymore.

The tests pass without them so I'll remove them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135237/new/

https://reviews.llvm.org/D135237



More information about the llvm-commits mailing list