[PATCH] D135237: [llvm-reduce] Remove debug metadata elements

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: llvm/test/tools/llvm-reduce/remove-debug-info-nodes.ll:15-18
+; CHECK-INTERESTINGNESS-DAG: !{{DIGlobalVariable}}(
+; CHECK-INTERESTINGNESS-DAG: !{{DILocalVariable}}(name: "A"
+; CHECK-INTERESTINGNESS-DAG: !{{DILocalVariable}}(name: "B"
+; CHECK-INTERESTINGNESS-DAG: !{{DILocalVariable}}(name: "C"
----------------
The `DILocalVariable`s don't need `{{``}}` do they?


================
Comment at: llvm/test/tools/llvm-reduce/remove-metadata-elements.ll:24
+!5 = !DIGlobalVariableExpression(var: !6, expr: !DIExpression())
+; CHECK: !{{DIGlobalVariable}}(name: "interesting"
+!6 = distinct !DIGlobalVariable(name: "interesting", scope: !2, file: !3, line: 1, type: !7, isLocal: false, isDefinition: true)
----------------



================
Comment at: llvm/test/tools/llvm-reduce/remove-named-metadata-elements.ll:7
+!llvm.dbg.cu = !{!0, !1}
+; CHECK: !{{llvm.module.flags}} =
+; REDUCED-SAME: !{}
----------------



================
Comment at: llvm/tools/llvm-reduce/deltas/ReduceMetadata.cpp:104-106
+    if (VisitedNodes.contains(Node))
+      continue;
+    VisitedNodes.insert(Node);
----------------



================
Comment at: llvm/tools/llvm-reduce/deltas/ReduceMetadata.cpp:109-110
+      auto *Op = Node->getOperand(I).get();
+      if (isa_and_nonnull<MDNode>(Op))
+        NodesToVisit.insert(cast<MDNode>(Op));
+      if (isa_and_nonnull<MDTuple>(Op))
----------------



================
Comment at: llvm/tools/llvm-reduce/deltas/ReduceMetadata.cpp:117-119
+  for (auto Pair : OperandsOfTuples) {
+    auto *Node = Pair.first;
+    unsigned NodeOpID = Pair.second;
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135237/new/

https://reviews.llvm.org/D135237