[PATCH] D109240: GlobalISel: Artifact combine merge-like opcode and unmerge into copy

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 29 12:17:36 PDT 2022


arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM in the name of making progress. We do need to start moving all of this stuff into ArtifactValueFinder though



================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/LegalizationArtifactCombiner.h:1093
+                           GISelChangeObserver &Observer) {
+    Builder.setInstrAndDebugLoc(MI);
+    Register FirstElt = MI.getReg(1);
----------------
Move this below to where instructions could actually be inserted


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109240/new/

https://reviews.llvm.org/D109240



More information about the llvm-commits mailing list