[PATCH] D134826: [mlir][MemRef] Simplify extract_strided_metadata(collapse_shape)

[Alex Zinenko via Phabricator via llvm-commits]

ftynse added inline comments.


================
Comment at: mlir/lib/Dialect/MemRef/Transforms/SimplifyExtractStridedMetadata.cpp:345
+                                ArrayRef<OpFoldResult> values,
+                                std::function<bool(int64_t)> isDynamic) {
+  AffineExpr productOfValues = builder.getAffineConstantExpr(1);
----------------
qcolombet wrote:
> I thought I would need that more than once, but turned out I used it only once.
> Let me know if you want that we get rid of it.
Nit: `function_ref` if the function isn't stored.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134826/new/

https://reviews.llvm.org/D134826