[PATCH] D134826: [mlir][MemRef] Simplify extract_strided_metadata(collapse_shape)

[lorenzo chelini via Phabricator via llvm-commits]

chelini added inline comments.


================
Comment at: mlir/lib/Dialect/MemRef/Transforms/SimplifyExtractStridedMetadata.cpp:342
+/// \pre for all index in indices: index < maybeConstants.size()
+OpFoldResult getProductOfValues(ArrayRef<int64_t> indices, OpBuilder &builder,
+                                Location loc, ArrayRef<int64_t> maybeConstants,
----------------
static ?


================
Comment at: mlir/lib/Dialect/MemRef/Transforms/SimplifyExtractStridedMetadata.cpp:420
+/// dimension.
+SmallVector<OpFoldResult>
+getCollapsedStride(memref::CollapseShapeOp collapseShape, OpBuilder &builder,
----------------
static ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134826/new/

https://reviews.llvm.org/D134826