[PATCH] D134862: [AMDGPU][GISel] Update `isCanonicalized`

Thu Sep 29 03:20:30 PDT 2022

foad added a comment.

In D134862#3823304 <https://reviews.llvm.org/D134862#3823304>, @Pierre-vh wrote:

> In D134862#3823194 <https://reviews.llvm.org/D134862#3823194>, @foad wrote:
>
>> LGTM. (I'm not 100%  sure about G_FREM but I assume it expands to something that will flush denormals if appropriate?)
>
> I think it's fine as this mimics the DAG's implementation. I can still remove FREM if you're not sure about it as I don't really need it added right now (I just added it for completeness).

I agree it's fine. It looks like it normally expands to some combination of div/mul/trunc/fma, i.e. normal fp instructions which will canonicalize.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134862/new/

https://reviews.llvm.org/D134862