[PATCH] D134862: [AMDGPU][GISel] Update `isCanonicalized`

Pierre van Houtryve via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 29 03:17:45 PDT 2022


Pierre-vh added a comment.

In D134862#3823194 <https://reviews.llvm.org/D134862#3823194>, @foad wrote:

> LGTM. (I'm not 100%  sure about G_FREM but I assume it expands to something that will flush denormals if appropriate?)

I think it's fine as this mimics the DAG's implementation. I can still remove FREM if you're not sure about it as I don't really need it added right now (I just added it for completeness).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134862/new/

https://reviews.llvm.org/D134862



More information about the llvm-commits mailing list