[PATCH] D134662: [OpenMPIRBuilder] Migrate emitOffloadingArraysArgument from clang
Johannes Doerfert via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 28 10:09:28 PDT 2022
jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.
LG, nits below
================
Comment at: include/llvm/Frontend/OpenMP/OMPIRBuilder.h:1026
+ Value *MapNamesArray = nullptr;
+ /// Indicate whether any user-defined mapper exists.
+ };
----------------
Move to the bool.
================
Comment at: lib/Frontend/OpenMP/OMPIRBuilder.cpp:4007-4009
+ RTArgs.MapTypesArray = llvm::ConstantPointerNull::get(Int64PtrTy);
+ RTArgs.MapNamesArray = llvm::ConstantPointerNull::get(VoidPtrPtrTy);
+ RTArgs.MappersArray = llvm::ConstantPointerNull::get(VoidPtrPtrTy);
----------------
also below.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134662/new/
https://reviews.llvm.org/D134662
More information about the llvm-commits
mailing list