[PATCH] D134662: [OpenMPIRBuilder] Migrate emitOffloadingArraysArgument from clang

Wed Sep 28 09:22:12 PDT 2022

jsjodin marked an inline comment as done.
jsjodin added inline comments.

================
Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:3997-4001
+  auto Int8Ty = Type::getInt8Ty(M.getContext());
+  auto VoidPtrTy =  Int8Ty->getPointerTo(0);
+  auto VoidPtrPtrTy = VoidPtrTy->getPointerTo(0);
+  auto Int64Ty = Type::getInt64Ty(M.getContext());
+  auto Int64PtrTy = Int64Ty->getPointerTo();
----------------
jsjodin wrote:
> jdoerfert wrote:
> > These types should exist but I guess this is OK.
> It can be compressed by using PointerType *VoidPtrType = Type::getInt8PtrTy(C); I will also fix this, but in the next patch update.
Did minor cleanup.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134662/new/

https://reviews.llvm.org/D134662