[PATCH] D134621: [RISCV][WIP] Teach SExtWRemoval to recognize sign extended values that come from arguments.

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 28 07:40:11 PDT 2022


reames added a comment.

This looks reasonable to me, but I'm not knowledgeable enough of the argument lowering to know if this scheme is sound.  I'll defer to others on the review.



================
Comment at: llvm/lib/Target/RISCV/RISCVSExtWRemoval.cpp:321
+      const RISCVMachineFunctionInfo *RVFI =
+          MF->getInfo<RISCVMachineFunctionInfo>();
+      if (MI->getParent()->getBasicBlock() ==
----------------
These declarations can be pulled out of the loop.  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134621/new/

https://reviews.llvm.org/D134621



More information about the llvm-commits mailing list