[PATCH] D133823: Add APFloat and MLIR type support for fp8 (e5m2).

[Jacques Pienaar via Phabricator via llvm-commits]

jpienaar accepted this revision.
jpienaar added a comment.

Looks good thanks, naming discussions always fun.



================
Comment at: mlir/test/lib/Dialect/Test/TestOps.td:197
+def FloatAttrOp : TEST_Op<"float_attrs"> {
+  // TODO: Clean up the OpBase float type and attribute selectors so they
+  // can express all of the types.
----------------
I'll file an issue if you haven't already.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133823/new/

https://reviews.llvm.org/D133823