[PATCH] D133823: Add APFloat and MLIR type support for fp8 (e5m2).

Benjamin Kramer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 28 04:47:05 PDT 2022


bkramer added a comment.

In D133823#3820513 <https://reviews.llvm.org/D133823#3820513>, @stellaraccident wrote:

> Bkramer; was your intention to review both the APFloat and MLIR side of the patch? Just making sure that the MLIR side had a proper look before submitting and it wasn't clear to me from the commentary.

Both the LLVM and MLIR sides look good to me (but I have less experience on the MLIR side).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133823/new/

https://reviews.llvm.org/D133823



More information about the llvm-commits mailing list