[PATCH] D134758: [RISCV][SelectionDAGBuilder] Fix crash when copying a v1f32 vector between basic blocks.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:455
+    } else if (ValueSVT.isFloatingPoint() && PartEVT.isInteger()) {
+      EVT IntermediateType = EVT::getIntegerVT(*DAG.getContext(), ValueSize);
+      Val = DAG.getNode(ISD::TRUNCATE, DL, IntermediateType, Val);
----------------
RKSimon wrote:
> Is implicit truncation guaranteed?
> 
> A description comment might be useful.
I think so. The only case I know of this happening right now is PartEVT is i64 and ValueSVT is f32.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134758/new/

https://reviews.llvm.org/D134758