[PATCH] D134758: [RISCV][SelectionDAGBuilder] Fix crash when copying a v1f32 vector between basic blocks.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 27 13:03:06 PDT 2022


RKSimon added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:455
+    } else if (ValueSVT.isFloatingPoint() && PartEVT.isInteger()) {
+      EVT IntermediateType = EVT::getIntegerVT(*DAG.getContext(), ValueSize);
+      Val = DAG.getNode(ISD::TRUNCATE, DL, IntermediateType, Val);
----------------
Is implicit truncation guaranteed?

A description comment might be useful.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134758/new/

https://reviews.llvm.org/D134758



More information about the llvm-commits mailing list