[PATCH] D134531: [SCEV] Verify block disposition cache.

Mon Sep 26 12:17:46 PDT 2022

fhahn marked an inline comment as done.
fhahn added inline comments.

================
Comment at: llvm/lib/Analysis/ScalarEvolution.cpp:14000
+      const BasicBlock *BB = V.getPointer();
+      const auto RecomputedDisposition = SE2.getBlockDisposition(S, BB);
+      if (CachedDisposition != RecomputedDisposition) {
----------------
nikic wrote:
> Hm, do we have issues with dangling blocks here? Did you check whether enabling scev verification + asan works (or maybe quicker: add a manual check that the BB is in the function block set).
I think the last issue should be fixed with D134663, at least when bootstrapping clang with ASAN on arm64 macOS 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134531/new/

https://reviews.llvm.org/D134531