[PATCH] D134531: [SCEV] Verify block disposition cache.

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 26 06:17:08 PDT 2022


nikic added inline comments.


================
Comment at: llvm/lib/Analysis/ScalarEvolution.cpp:14000
+      const BasicBlock *BB = V.getPointer();
+      const auto RecomputedDisposition = SE2.getBlockDisposition(S, BB);
+      if (CachedDisposition != RecomputedDisposition) {
----------------
Hm, do we have issues with dangling blocks here? Did you check whether enabling scev verification + asan works (or maybe quicker: add a manual check that the BB is in the function block set).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134531/new/

https://reviews.llvm.org/D134531



More information about the llvm-commits mailing list