[PATCH] D134279: [MustExec][LICM] Handle latch being part of an inner cycle (PR57780)

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 26 06:10:33 PDT 2022


nikic added a comment.

In D134279#3810852 <https://reviews.llvm.org/D134279#3810852>, @mkazantsev wrote:

> I need to think more about this particular one, but my general preference would be "do nothing if there is an irreducible loop". Is it an option here?

I've given this some more thought, and the irreducible control flow is ultimately not relevant: We only need the latch to be part of an inner cycle. The LICM issue does not reproduce with an inner natural cycle (because we don't hoist instructions from inner loops), but we can see this when testing MustExecute directly.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134279/new/

https://reviews.llvm.org/D134279



More information about the llvm-commits mailing list