[PATCH] D131389: [AArch64] Add Missing v8.8a ALLINT PSTATE

Mon Sep 26 02:05:32 PDT 2022

tmatheson accepted this revision.
tmatheson added a comment.
This revision is now accepted and ready to land.

Couple of suggestions but otherwise LGTM.

================
Comment at: llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp:1125
+
+    auto PState = AArch64PState::lookupPStateByEncoding(SysReg.PStateField);
+    if (!PState)
----------------
Please write the type name explicitly where auto is not obvious.

================
Comment at: llvm/test/MC/AArch64/armv8.1a-pan.s:18
   msr pan, #-1
-  msr pan, #2
   msr pan, w0
----------------
Maybe keep the tests with non-0/1 but valid immediates.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131389/new/

https://reviews.llvm.org/D131389