[PATCH] D134582: [LoongArch] Support lowering frames larger than 2048 bytes

[Lu Weining via Phabricator via llvm-commits]

SixWeining added inline comments.


================
Comment at: llvm/lib/Target/LoongArch/LoongArchRegisterInfo.cpp:138
+    // The offset won't fit in an immediate, so use a scratch register instead
+    // Modify Offset and FrameReg appropriately
+    Register ScratchReg = MRI.createVirtualRegister(&LoongArch::GPRRegClass);
----------------
xen0n wrote:
> SixWeining wrote:
> > 
> No it's two sentences so the suggestion is wrong.
> 
> I'll add the trailing periods though (obviously the current expression can be interpreted ambiguously by non-native speakers judging from this). Thanks for the catch!
Oh, my bad :) Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134582/new/

https://reviews.llvm.org/D134582