[PATCH] D134582: [LoongArch] Support lowering frames larger than 2048 bytes
WÁNG Xuěruì via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Sep 25 20:53:29 PDT 2022
xen0n marked an inline comment as done.
xen0n added inline comments.
================
Comment at: llvm/lib/Target/LoongArch/LoongArchRegisterInfo.cpp:138
+ // The offset won't fit in an immediate, so use a scratch register instead
+ // Modify Offset and FrameReg appropriately
+ Register ScratchReg = MRI.createVirtualRegister(&LoongArch::GPRRegClass);
----------------
SixWeining wrote:
>
No it's two sentences so the suggestion is wrong.
I'll add the trailing periods though (obviously the current expression can be interpreted ambiguously by non-native speakers judging from this). Thanks for the catch!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134582/new/
https://reviews.llvm.org/D134582
More information about the llvm-commits
mailing list