[PATCH] D133452: [ORC] Fix auto-claim of weak defs in ObjectLinkingLayer

[Lang Hames via Phabricator via llvm-commits]

lhames added a comment.

In D133452#3809202 <https://reviews.llvm.org/D133452#3809202>, @Hahnfeld wrote:

> But that's what I'm saying: It just works, even after reverting.

It fails consistently for me if I revert the given patch. My test config is docker container running x86-64 Linux, with a Debug build of Clang/LLVM, compiling the test case with

  % clang++ -emit-llvm -S -o eh.ll eh.cpp

and running it with

  % lli -relocation-model=pic -jit-linker=jitlink eh.ll

With 4dc110a4b83 <https://reviews.llvm.org/rG4dc110a4b83c625502092b127ca0e9eb13824297> applied this works as expected. With that commit reverted it crashes (from memory the original failure mode was an error, but I may have misremembered, or intervening patches may have affected it).

What config are you testing with?

This is still a side-issue for the actual review though -- I just need to find time to look at what RISCV is doing with this IR that's producing a weak def that's not needed locally, but still needed somewhere.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133452/new/

https://reviews.llvm.org/D133452