[PATCH] D133452: [ORC] Fix auto-claim of weak defs in ObjectLinkingLayer

[Jonas Hahnfeld via Phabricator via llvm-commits]

Hahnfeld added a comment.

In D133452#3809168 <https://reviews.llvm.org/D133452#3809168>, @lhames wrote:

> In D133452#3795518 <https://reviews.llvm.org/D133452#3795518>, @Hahnfeld wrote:
>
>> In D133452#3782574 <https://reviews.llvm.org/D133452#3782574>, @lhames wrote:
>>
>>> I think I botched the commit message for that commit and that might be contributing to the confusion: Prior to that commit any weak symbol that was //referenced in the graph//, but //wasn't// in the responsibility set was turned into an external symbol (not dead-stripped, as the commit message says). That would result in a missing definition error within the graph containing the definition. That was definitely a bug, and the original commit fixed that issue.
>>
>> But then, what test case do I have to run to see the problem after reverting that commit locally?
>
> As mentioned in the commit message, there was no testcase added because `lli` did not support JITLink at the time.
>
> Stefan fixed that in 23973e0aac1e1 <https://reviews.llvm.org/rG23973e0aac1e13eecebc62547585815e8352f65c>, so now you should be able to run
>
>   lli -relocation-model=pic -jit-linker=jitlink eh.ll
>
> where eh.ll is the IR for your testcase.

But that's what I'm saying: It just works, even after reverting.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133452/new/

https://reviews.llvm.org/D133452