[PATCH] D134413: [AARCH64][CostModel] Modified the cost of mask vector load/store

Fri Sep 23 08:42:34 PDT 2022

david-arm accepted this revision.
david-arm added a comment.
This revision is now accepted and ready to land.

> In the test case of sve-intrinsics-mask-ldst-ext.ll, I found that the instruction of llvm.masked.load.nxv/llvm.masked.store.nxv only corresponds to one assembly, so I think its correct cost should be 1

OK thanks for the reply. The problem is that the cost isn't always due to the number of instructions, but also the cost in hardware of that instruction. In this particular case though, I think that the SVE ld1/st1 instructions are around the same cost as NEON loads/stores. Also, normal load/store IR nodes get lowered to a SVE ld1/st1, which have a cost of 1. I think this change fixes that inconsistency so I'm happy with it!

LGTM!

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134413/new/

https://reviews.llvm.org/D134413