[PATCH] D133172: [lit] Extend DEFINE/REDEFINE with function substitutions

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

I'll be honest, I don't like the syntax of this, so much so that I think I'd prefer people use the existing method of providing function arguments for these substitutions (i.e. DEFINE then REDEFINE them as needed) versus this. The complex regex required in the lit scripts to make this format work also doesn't help this solution's case.

Is the following format at all viable?

  %{func(arg1, arg2)}

This would require lit to treat these kinds of substitutions specially, but the format including `(` and `)` in the name means this would at least be fairly easy to detect.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133172/new/

https://reviews.llvm.org/D133172