[PATCH] D134288: [flang] Write semantics test for atomic_define

[Damian Rouson via Phabricator via llvm-commits]

rouson accepted this revision.
rouson added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: flang/test/Semantics/atomic04.f90:13
+  integer :: status, default_kind_coarray[*], coindexed_status[*], extra_arg, repeated_status, status_array(10), default_int_val
+  integer(kind=1) :: kind1_coarray[*]
+  real :: non_integer_coarray[*], non_int_or_logical
----------------
Please add a comment to document any assumptions required for this code to be valid, e.g., the assumption that atomic_int_kind /= 1 (which is currently true but doesn't necessarily have to be true forevermore).


================
Comment at: flang/test/Semantics/atomic04.f90:23
+  call atomic_define(scalar_coarray[1], val)
+  call atomic_define(scalar_coarray, val, status)
+  call atomic_define(scalar_coarray[1], val, status)
----------------
In lines 23-29, the second argument could sometimes be `default_int_val` to vary the testing regime.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134288/new/

https://reviews.llvm.org/D134288