[llvm] f19cc79 - [AMDGPU] Disable fp atomic to s_denorm_mode hazard for GFX11
Jay Foad via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 20 09:43:47 PDT 2022
Author: Jay Foad
Date: 2022-09-20T17:40:49+01:00
New Revision: f19cc793d28067c3f7a4c17806bbe3fc6db773c9
URL: https://github.com/llvm/llvm-project/commit/f19cc793d28067c3f7a4c17806bbe3fc6db773c9
DIFF: https://github.com/llvm/llvm-project/commit/f19cc793d28067c3f7a4c17806bbe3fc6db773c9.diff
LOG: [AMDGPU] Disable fp atomic to s_denorm_mode hazard for GFX11
This hazard only exists on GFX10.
Differential Revision: https://reviews.llvm.org/D134276
Added:
Modified:
llvm/lib/Target/AMDGPU/GCNHazardRecognizer.cpp
llvm/lib/Target/AMDGPU/GCNSubtarget.h
llvm/test/CodeGen/AMDGPU/fp-atomic-to-s_denormmode.mir
Removed:
################################################################################
diff --git a/llvm/lib/Target/AMDGPU/GCNHazardRecognizer.cpp b/llvm/lib/Target/AMDGPU/GCNHazardRecognizer.cpp
index e2579d41b930..c015936cb6d8 100644
--- a/llvm/lib/Target/AMDGPU/GCNHazardRecognizer.cpp
+++ b/llvm/lib/Target/AMDGPU/GCNHazardRecognizer.cpp
@@ -1884,6 +1884,9 @@ int GCNHazardRecognizer::checkNSAtoVMEMHazard(MachineInstr *MI) {
int GCNHazardRecognizer::checkFPAtomicToDenormModeHazard(MachineInstr *MI) {
int FPAtomicToDenormModeWaitStates = 3;
+ if (!ST.hasFPAtomicToDenormModeHazard())
+ return 0;
+
if (MI->getOpcode() != AMDGPU::S_DENORM_MODE)
return 0;
diff --git a/llvm/lib/Target/AMDGPU/GCNSubtarget.h b/llvm/lib/Target/AMDGPU/GCNSubtarget.h
index d161f4aa13ec..eb218ee493d6 100644
--- a/llvm/lib/Target/AMDGPU/GCNSubtarget.h
+++ b/llvm/lib/Target/AMDGPU/GCNSubtarget.h
@@ -1040,6 +1040,10 @@ class GCNSubtarget final : public AMDGPUGenSubtargetInfo,
bool hasGFX90AInsts() const { return GFX90AInsts; }
+ bool hasFPAtomicToDenormModeHazard() const {
+ return getGeneration() == GFX10;
+ }
+
bool hasVOP3DPP() const { return getGeneration() >= GFX11; }
bool hasLdsDirect() const { return getGeneration() >= GFX11; }
diff --git a/llvm/test/CodeGen/AMDGPU/fp-atomic-to-s_denormmode.mir b/llvm/test/CodeGen/AMDGPU/fp-atomic-to-s_denormmode.mir
index 2bbbe45bb407..1969f9bdcd86 100644
--- a/llvm/test/CodeGen/AMDGPU/fp-atomic-to-s_denormmode.mir
+++ b/llvm/test/CodeGen/AMDGPU/fp-atomic-to-s_denormmode.mir
@@ -1,9 +1,9 @@
-# RUN: llc -march=amdgcn -mcpu=gfx1010 -verify-machineinstrs -run-pass post-RA-hazard-rec -o - %s | FileCheck -check-prefix=GCN %s
-# RUN: llc -march=amdgcn -mcpu=gfx1100 -verify-machineinstrs -run-pass post-RA-hazard-rec -o - %s | FileCheck -check-prefix=GCN %s
+# RUN: llc -march=amdgcn -mcpu=gfx1010 -verify-machineinstrs -run-pass post-RA-hazard-rec -o - %s | FileCheck -check-prefixes=GCN,GFX10 %s
+# RUN: llc -march=amdgcn -mcpu=gfx1100 -verify-machineinstrs -run-pass post-RA-hazard-rec -o - %s | FileCheck -check-prefixes=GCN %s
# GCN-LABEL: name: flat_atomic_fcmpswap_to_s_denorm_mode
# GCN: FLAT_ATOMIC_FCMPSWAP
-# GCN-NEXT: S_NOP 2
+# GFX10-NEXT: S_NOP 2
# GCN-NEXT: S_DENORM_MODE
---
name: flat_atomic_fcmpswap_to_s_denorm_mode
@@ -15,7 +15,7 @@ body: |
# GCN-LABEL: name: flat_atomic_fcmpswap_x2_to_s_denorm_mode
# GCN: FLAT_ATOMIC_FCMPSWAP_X2
-# GCN-NEXT: S_NOP 2
+# GFX10-NEXT: S_NOP 2
# GCN-NEXT: S_DENORM_MODE
---
name: flat_atomic_fcmpswap_x2_to_s_denorm_mode
@@ -27,7 +27,7 @@ body: |
# GCN-LABEL: name: flat_atomic_fmax_to_s_denorm_mode
# GCN: FLAT_ATOMIC_FMAX
-# GCN-NEXT: S_NOP 2
+# GFX10-NEXT: S_NOP 2
# GCN-NEXT: S_DENORM_MODE
---
name: flat_atomic_fmax_to_s_denorm_mode
@@ -39,7 +39,7 @@ body: |
# GCN-LABEL: name: flat_atomic_fmax_x2_to_s_denorm_mode
# GCN: FLAT_ATOMIC_FMAX_X2
-# GCN-NEXT: S_NOP 2
+# GFX10-NEXT: S_NOP 2
# GCN-NEXT: S_DENORM_MODE
---
name: flat_atomic_fmax_x2_to_s_denorm_mode
@@ -51,7 +51,7 @@ body: |
# GCN-LABEL: name: flat_atomic_fmin_to_s_denorm_mode
# GCN: FLAT_ATOMIC_FMIN
-# GCN-NEXT: S_NOP 2
+# GFX10-NEXT: S_NOP 2
# GCN-NEXT: S_DENORM_MODE
---
name: flat_atomic_fmin_to_s_denorm_mode
@@ -63,7 +63,7 @@ body: |
# GCN-LABEL: name: flat_atomic_fmin_x2_to_s_denorm_mode
# GCN: FLAT_ATOMIC_FMIN_X2
-# GCN-NEXT: S_NOP 2
+# GFX10-NEXT: S_NOP 2
# GCN-NEXT: S_DENORM_MODE
---
name: flat_atomic_fmin_x2_to_s_denorm_mode
@@ -75,7 +75,7 @@ body: |
# GCN-LABEL: name: flat_atomic_fcmpswap_x2_rtn_to_s_denorm_mode
# GCN: FLAT_ATOMIC_FCMPSWAP_X2_RTN
-# GCN-NEXT: S_NOP 2
+# GFX10-NEXT: S_NOP 2
# GCN-NEXT: S_DENORM_MODE
---
name: flat_atomic_fcmpswap_x2_rtn_to_s_denorm_mode
@@ -87,7 +87,7 @@ body: |
# GCN-LABEL: name: flat_atomic_fmax_rtn_to_s_denorm_mode
# GCN: FLAT_ATOMIC_FMAX_RTN
-# GCN-NEXT: S_NOP 2
+# GFX10-NEXT: S_NOP 2
# GCN-NEXT: S_DENORM_MODE
---
name: flat_atomic_fmax_rtn_to_s_denorm_mode
@@ -99,7 +99,7 @@ body: |
# GCN-LABEL: name: flat_atomic_fmax_x2_rtn_to_s_denorm_mode
# GCN: FLAT_ATOMIC_FMAX_X2_RTN
-# GCN-NEXT: S_NOP 2
+# GFX10-NEXT: S_NOP 2
# GCN-NEXT: S_DENORM_MODE
---
name: flat_atomic_fmax_x2_rtn_to_s_denorm_mode
@@ -111,7 +111,7 @@ body: |
# GCN-LABEL: name: flat_atomic_fmin_rtn_to_s_denorm_mode
# GCN: FLAT_ATOMIC_FMIN_RTN
-# GCN-NEXT: S_NOP 2
+# GFX10-NEXT: S_NOP 2
# GCN-NEXT: S_DENORM_MODE
---
name: flat_atomic_fmin_rtn_to_s_denorm_mode
@@ -123,7 +123,7 @@ body: |
# GCN-LABEL: name: flat_atomic_fmin_x2_rtn_to_s_denorm_mode
# GCN: FLAT_ATOMIC_FMIN_X2_RTN
-# GCN-NEXT: S_NOP 2
+# GFX10-NEXT: S_NOP 2
# GCN-NEXT: S_DENORM_MODE
---
name: flat_atomic_fmin_x2_rtn_to_s_denorm_mode
@@ -135,7 +135,7 @@ body: |
# GCN-LABEL: name: flat_atomic_fcmpswap_rtn_to_s_denorm_mode
# GCN: FLAT_ATOMIC_FCMPSWAP_RTN
-# GCN-NEXT: S_NOP 2
+# GFX10-NEXT: S_NOP 2
# GCN-NEXT: S_DENORM_MODE
---
name: flat_atomic_fcmpswap_rtn_to_s_denorm_mode
@@ -147,7 +147,7 @@ body: |
# GCN-LABEL: name: global_atomic_fcmpswap_to_s_denorm_mode
# GCN: GLOBAL_ATOMIC_FCMPSWAP
-# GCN-NEXT: S_NOP 2
+# GFX10-NEXT: S_NOP 2
# GCN-NEXT: S_DENORM_MODE
---
name: global_atomic_fcmpswap_to_s_denorm_mode
@@ -159,7 +159,7 @@ body: |
# GCN-LABEL: name: global_atomic_fcmpswap_x2_to_s_denorm_mode
# GCN: GLOBAL_ATOMIC_FCMPSWAP_X2
-# GCN-NEXT: S_NOP 2
+# GFX10-NEXT: S_NOP 2
# GCN-NEXT: S_DENORM_MODE
---
name: global_atomic_fcmpswap_x2_to_s_denorm_mode
@@ -171,7 +171,7 @@ body: |
# GCN-LABEL: name: global_atomic_fmax_to_s_denorm_mode
# GCN: GLOBAL_ATOMIC_FMAX
-# GCN-NEXT: S_NOP 2
+# GFX10-NEXT: S_NOP 2
# GCN-NEXT: S_DENORM_MODE
---
name: global_atomic_fmax_to_s_denorm_mode
@@ -183,7 +183,7 @@ body: |
# GCN-LABEL: name: global_atomic_fmax_x2_to_s_denorm_mode
# GCN: GLOBAL_ATOMIC_FMAX_X2
-# GCN-NEXT: S_NOP 2
+# GFX10-NEXT: S_NOP 2
# GCN-NEXT: S_DENORM_MODE
---
name: global_atomic_fmax_x2_to_s_denorm_mode
@@ -195,7 +195,7 @@ body: |
# GCN-LABEL: name: global_atomic_fmin_to_s_denorm_mode
# GCN: GLOBAL_ATOMIC_FMIN
-# GCN-NEXT: S_NOP 2
+# GFX10-NEXT: S_NOP 2
# GCN-NEXT: S_DENORM_MODE
---
name: global_atomic_fmin_to_s_denorm_mode
@@ -207,7 +207,7 @@ body: |
# GCN-LABEL: name: global_atomic_fmin_x2_to_s_denorm_mode
# GCN: GLOBAL_ATOMIC_FMIN_X2
-# GCN-NEXT: S_NOP 2
+# GFX10-NEXT: S_NOP 2
# GCN-NEXT: S_DENORM_MODE
---
name: global_atomic_fmin_x2_to_s_denorm_mode
@@ -219,7 +219,7 @@ body: |
# GCN-LABEL: name: global_atomic_fcmpswap_rtn_to_s_denorm_mode
# GCN: GLOBAL_ATOMIC_FCMPSWAP_RTN
-# GCN-NEXT: S_NOP 2
+# GFX10-NEXT: S_NOP 2
# GCN-NEXT: S_DENORM_MODE
---
name: global_atomic_fcmpswap_rtn_to_s_denorm_mode
@@ -231,7 +231,7 @@ body: |
# GCN-LABEL: name: global_atomic_fcmpswap_x2_rtn_to_s_denorm_mode
# GCN: GLOBAL_ATOMIC_FCMPSWAP_X2_RTN
-# GCN-NEXT: S_NOP 2
+# GFX10-NEXT: S_NOP 2
# GCN-NEXT: S_DENORM_MODE
---
name: global_atomic_fcmpswap_x2_rtn_to_s_denorm_mode
@@ -243,7 +243,7 @@ body: |
# GCN-LABEL: name: global_atomic_fmax_rtn_to_s_denorm_mode
# GCN: GLOBAL_ATOMIC_FMAX_RTN
-# GCN-NEXT: S_NOP 2
+# GFX10-NEXT: S_NOP 2
# GCN-NEXT: S_DENORM_MODE
---
name: global_atomic_fmax_rtn_to_s_denorm_mode
@@ -255,7 +255,7 @@ body: |
# GCN-LABEL: name: global_atomic_fmax_x2_rtn_to_s_denorm_mode
# GCN: GLOBAL_ATOMIC_FMAX_X2_RTN
-# GCN-NEXT: S_NOP 2
+# GFX10-NEXT: S_NOP 2
# GCN-NEXT: S_DENORM_MODE
---
name: global_atomic_fmax_x2_rtn_to_s_denorm_mode
@@ -267,7 +267,7 @@ body: |
# GCN-LABEL: name: global_atomic_fmin_rtn_to_s_denorm_mode
# GCN: GLOBAL_ATOMIC_FMIN_RTN
-# GCN-NEXT: S_NOP 2
+# GFX10-NEXT: S_NOP 2
# GCN-NEXT: S_DENORM_MODE
---
name: global_atomic_fmin_rtn_to_s_denorm_mode
@@ -279,7 +279,7 @@ body: |
# GCN-LABEL: name: global_atomic_fmin_x2_rtn_to_s_denorm_mode
# GCN: GLOBAL_ATOMIC_FMIN_X2_RTN
-# GCN-NEXT: S_NOP 2
+# GFX10-NEXT: S_NOP 2
# GCN-NEXT: S_DENORM_MODE
---
name: global_atomic_fmin_x2_rtn_to_s_denorm_mode
@@ -291,7 +291,7 @@ body: |
# GCN-LABEL: name: global_atomic_fcmpswap_saddr_to_s_denorm_mode
# GCN: GLOBAL_ATOMIC_FCMPSWAP_SADDR
-# GCN-NEXT: S_NOP 2
+# GFX10-NEXT: S_NOP 2
# GCN-NEXT: S_DENORM_MODE
---
name: global_atomic_fcmpswap_saddr_to_s_denorm_mode
@@ -303,7 +303,7 @@ body: |
# GCN-LABEL: name: global_atomic_fcmpswap_x2_saddr_rtn_to_s_denorm_mode
# GCN: GLOBAL_ATOMIC_FCMPSWAP_X2_SADDR_RTN
-# GCN-NEXT: S_NOP 2
+# GFX10-NEXT: S_NOP 2
# GCN-NEXT: S_DENORM_MODE
---
name: global_atomic_fcmpswap_x2_saddr_rtn_to_s_denorm_mode
@@ -315,7 +315,7 @@ body: |
# GCN-LABEL: name: global_atomic_fmax_saddr_rtn_to_s_denorm_mode
# GCN: GLOBAL_ATOMIC_FMAX_SADDR_RTN
-# GCN-NEXT: S_NOP 2
+# GFX10-NEXT: S_NOP 2
# GCN-NEXT: S_DENORM_MODE
---
name: global_atomic_fmax_saddr_rtn_to_s_denorm_mode
@@ -327,7 +327,7 @@ body: |
# GCN-LABEL: name: global_atomic_fmax_x2_saddr_rtn_to_s_denorm_mode
# GCN: GLOBAL_ATOMIC_FMAX_X2_SADDR_RTN
-# GCN-NEXT: S_NOP 2
+# GFX10-NEXT: S_NOP 2
# GCN-NEXT: S_DENORM_MODE
---
name: global_atomic_fmax_x2_saddr_rtn_to_s_denorm_mode
@@ -339,7 +339,7 @@ body: |
# GCN-LABEL: name: global_atomic_fmin_saddr_rtn_to_s_denorm_mode
# GCN: GLOBAL_ATOMIC_FMIN_SADDR_RTN
-# GCN-NEXT: S_NOP 2
+# GFX10-NEXT: S_NOP 2
# GCN-NEXT: S_DENORM_MODE
---
name: global_atomic_fmin_saddr_rtn_to_s_denorm_mode
@@ -351,7 +351,7 @@ body: |
# GCN-LABEL: name: global_atomic_fmin_x2_saddr_rtn_to_s_denorm_mode
# GCN: GLOBAL_ATOMIC_FMIN_X2_SADDR_RTN
-# GCN-NEXT: S_NOP 2
+# GFX10-NEXT: S_NOP 2
# GCN-NEXT: S_DENORM_MODE
---
name: global_atomic_fmin_x2_saddr_rtn_to_s_denorm_mode
More information about the llvm-commits
mailing list