[PATCH] D134397: [NFC] Refactor dxil metadata code

[Chris Bieneman via Phabricator via llvm-commits]

beanz marked an inline comment as done.
beanz added inline comments.


================
Comment at: llvm/lib/Target/DirectX/DXILMetadata.h:22
+
+class ValidationVersionMD {
+  NamedMDNode *Entry;
----------------
python3kgae wrote:
> Maybe ValidatorVersionMD?
I like that name better, will update.


================
Comment at: llvm/lib/Target/DirectX/DXILMetadata.h:25
+
+public:
+  ValidationVersionMD(Module &M);
----------------
python3kgae wrote:
> Shall we add something like VersionTuple getValidationVersion() to read the version?
I don't want to add an API that we don't currently have a use for. I don't see any reason we couldn't add this in the future, but right now we don't need it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134397/new/

https://reviews.llvm.org/D134397