[PATCH] D134397: [NFC] Refactor dxil metadata code
Xiang Li via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 21 16:47:50 PDT 2022
python3kgae added inline comments.
================
Comment at: llvm/lib/Target/DirectX/DXILMetadata.h:22
+
+class ValidationVersionMD {
+ NamedMDNode *Entry;
----------------
Maybe ValidatorVersionMD?
================
Comment at: llvm/lib/Target/DirectX/DXILMetadata.h:25
+
+public:
+ ValidationVersionMD(Module &M);
----------------
Shall we add something like VersionTuple getValidationVersion() to read the version?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134397/new/
https://reviews.llvm.org/D134397
More information about the llvm-commits
mailing list