[PATCH] D133003: [ELF] Parallelize relocation scanning
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 21 11:33:31 PDT 2022
MaskRay added a comment.
(The lack of thread_local problem on some configurations of Windows/zOS has been resolved.)
In D133003#3806508 <https://reviews.llvm.org/D133003#3806508>, @hans wrote:
> In D133003#3805979 <https://reviews.llvm.org/D133003#3805979>, @hans wrote:
>
>> We're seeing non-deterministic build output after this change: https://bugs.chromium.org/p/chromium/issues/detail?id=1364380
>
> I've put an lld repro here: https://drive.google.com/file/d/19zRK4jUxghCA5Pg_OJUugLM-D4yZ7iQR/view?usp=sharing (1.4 GB, requires google.com login)
Thanks for the reproduce. The nondeterminism is due to --pack-dyn-relocs=android.
I suspected whether it had trouble in a previous revision but after reading some code I thought it was ok.
> I'll remove AndroidPackedRelocationSection does not support parallelism. . It works with deterministic parallelism.
So the section still has some problems. `--pack-dyn-relocs=relr` is deterministic from the many experiments I have done.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133003/new/
https://reviews.llvm.org/D133003
More information about the llvm-commits
mailing list