[PATCH] D133687: [LoopVectorize][Fix] Crash when invariant store address is calculated inside loop

[mgabka via Phabricator via llvm-commits]

mgabka added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorizationLegality.cpp:937
+      !getReductionVars().empty()) {
+    // For each invariant address, check its last stored value is unconditional
+    // and the address is not calculated inside the loop.
----------------
nit: "check its" -> "check if"


================
Comment at: llvm/test/Transforms/LoopVectorize/reduction-with-invariant-store.ll:517
+
+define void @reduc_store_invariant_calucalated_inside_loop(i32* %dst, i32* readonly %src) {
+; CHECK-LABEL: @reduc_store_invariant_calucalated_inside_loop
----------------
nit: maybe better to call it : reduc_store_invariant_addr_not_hoisted ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133687/new/

https://reviews.llvm.org/D133687