[PATCH] D128014: [AMDGPU] Improve assembler + disassembler handling of kernel descriptors

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/ELF/AMDGPU/kd-gfx10.s:3
+
+; RUN: split-file %s %t.dir
+
----------------
scott.linder wrote:
> MaskRay wrote:
> > When there are multiple files, consider:
> > 
> > `; RUN: rm -rf %t && split-file %s %t && cd %t`
> > 
> > then just use relative filenames below (remove all `%t`)
> In working on the NFC portion separately the `rm -rf %t` portion didn't seem to have a clear use, and was present in ~40% of the uses of `split-file`, so I removed it.
> 
> Is there a particular reason to include it?
I don't know if this is what @MaskRay has in mind, but failure to delete the folder would mean stale files being left around, if the test is ever changed, potentially leading to surprising behaviour.

It's also typically necessary for llvm-ar invocations, although that doesn't seem relevant here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128014/new/

https://reviews.llvm.org/D128014