[PATCH] D128014: [AMDGPU] Improve assembler + disassembler handling of kernel descriptors

[Scott Linder via Phabricator via llvm-commits]

scott.linder added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/ELF/AMDGPU/kd-gfx10.s:3
+
+; RUN: split-file %s %t.dir
+
----------------
MaskRay wrote:
> When there are multiple files, consider:
> 
> `; RUN: rm -rf %t && split-file %s %t && cd %t`
> 
> then just use relative filenames below (remove all `%t`)
In working on the NFC portion separately the `rm -rf %t` portion didn't seem to have a clear use, and was present in ~40% of the uses of `split-file`, so I removed it.

Is there a particular reason to include it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128014/new/

https://reviews.llvm.org/D128014