[PATCH] D134278: [bolt] Fix (part of) dylib compatibility

[Rafael Auler via Phabricator via llvm-commits]

rafauler requested changes to this revision.
rafauler added a comment.
This revision now requires changes to proceed.

Thanks for working on fixing this! The llvm-bolt-fuzzer target doesn't seem quite right, could you take a look?



================
Comment at: bolt/tools/llvm-bolt-fuzzer/CMakeLists.txt:2
 set(LLVM_LINK_COMPONENTS
-  BOLTRewrite
   ${LLVM_TARGETS_TO_BUILD}
----------------
This is basically the only link from llvm-bolt-fuzzer with BOLT. We need to link it somehow. Using this diff, it fails to build for me with:

ld.lld: error: undefined symbol: opts::OutputFilename[abi:cxx11]
>>> referenced by llvm-bolt-fuzzer.cpp:25 (/home/rafaelauler/server-llvm/llvm/llvm-project/bolt/tools/llvm-bolt-fuzzer/llvm-bolt-fuzzer.cpp:25)
>>>               tools/bolt/tools/llvm-bolt-fuzzer/CMakeFiles/llvm-bolt-fuzzer.dir/llvm-bolt-fuzzer.cpp.o:(LLVMFuzzerTestOneInput)

To test a fuzzer target, remember to add these two options to cmake:

   -DLLVM_USE_SANITIZER=Address
   -DLLVM_USE_SANITIZE_COVERAGE=On


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134278/new/

https://reviews.llvm.org/D134278