[PATCH] D134278: [bolt] Fix (part of) dylib compatibility

[serge via Phabricator via llvm-commits]

serge-sans-paille created this revision.
serge-sans-paille added reviewers: sylvestre.ledru, rafaelauler.
Herald added subscribers: treapster, ayermolo, pengfei.
Herald added a reviewer: rafauler.
Herald added a reviewer: Amir.
Herald added a reviewer: maksfb.
Herald added a project: All.
serge-sans-paille requested review of this revision.
Herald added subscribers: llvm-commits, yota9.
Herald added a project: LLVM.

Non-LLVM components should not be listed as part of LLVM_LINK_COMPONENTS.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D134278

Files:
  bolt/lib/Target/AArch64/CMakeLists.txt
  bolt/lib/Target/X86/CMakeLists.txt
  bolt/tools/llvm-bolt-fuzzer/CMakeLists.txt


Index: bolt/tools/llvm-bolt-fuzzer/CMakeLists.txt
===================================================================
--- bolt/tools/llvm-bolt-fuzzer/CMakeLists.txt
+++ bolt/tools/llvm-bolt-fuzzer/CMakeLists.txt
@@ -1,5 +1,4 @@
 set(LLVM_LINK_COMPONENTS
-  BOLTRewrite
   ${LLVM_TARGETS_TO_BUILD}
   )
 
Index: bolt/lib/Target/X86/CMakeLists.txt
===================================================================
--- bolt/lib/Target/X86/CMakeLists.txt
+++ bolt/lib/Target/X86/CMakeLists.txt
@@ -1,6 +1,4 @@
 set(LLVM_LINK_COMPONENTS
-  BOLTCore
-  BOLTUtils
   MC
   MCDisassembler
   Support
@@ -15,6 +13,8 @@
   X86CommonTableGen
   )
 
+target_link_libraries(LLVMBOLTTargetX86 PRIVATE LLVMBOLTCore LLVMBOLTUtils)
+
 include_directories(
   ${LLVM_MAIN_SRC_DIR}/lib/Target/X86
   ${LLVM_BINARY_DIR}/lib/Target/X86
Index: bolt/lib/Target/AArch64/CMakeLists.txt
===================================================================
--- bolt/lib/Target/AArch64/CMakeLists.txt
+++ bolt/lib/Target/AArch64/CMakeLists.txt
@@ -1,5 +1,4 @@
 set(LLVM_LINK_COMPONENTS
-  BOLTCore
   MC
   Support
   AArch64Desc
@@ -12,6 +11,8 @@
   AArch64CommonTableGen
   )
 
+target_link_libraries(LLVMBOLTTargetAArch64 PRIVATE LLVMBOLTCore)
+
 include_directories(
   ${LLVM_MAIN_SRC_DIR}/lib/Target/AArch64
   ${LLVM_BINARY_DIR}/lib/Target/AArch64


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D134278.461546.patch
Type: text/x-patch
Size: 1328 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220920/d6fd0715/attachment.bin>