[PATCH] D134218: [VPlan] Sink non-uniform recieps for scalar plans.

Ayal Zaks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 20 02:44:47 PDT 2022


Ayal accepted this revision.
Ayal added a comment.
This revision is now accepted and ready to land.

LGTM.

This is essentially saying that for VF=1 every recipe is uniform (across VF lanes), or none are.
Perhaps this should be done more 'uniformly', as in CM.isUniformAfterVectorization(I, VF) which returns true if (VF.isScalar()) regardless of I.



================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:2655
 
+  bool hasScalarVFOnly() const { return VFs.size() == 1 && VFs[0].isScalar(); }
+
----------------
nit: might also be useful when printing VF range of VPlan, currently set in VPlan's name.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134218/new/

https://reviews.llvm.org/D134218



More information about the llvm-commits mailing list